-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
- also fix javadoc and bump dependencies
Fails because the API answered to slow. I'll add a loop to wait for completion. |
@bastiandoetsch does that require any changes in the plugin as well? if so, could you please open PR with such changes so we could check how it works all together? |
@ArtsiomCh Only referencing the new client. No code update should be needed, just a dependency update. |
@bastiandoetsch @aldanchenko Is the way bundle gets created here (sending hash + file contents in the first API request) same as in Visual Studio snyk/snyk-visual-studio-plugin#61? If not, let's unify the implementation to be consistent please. |
I think it is working the same, but this ticket should not be about synchronizing the plugins - that would be scope creep and much potentially much bigger :). |
Made a quick look... and it looks good. Well done @bastiandoetsch ! |
src/integTest/java/ai/deepcode/javaclient/DeepCodeRestApiTest.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/core/AnalysisDataBase.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/core/DeepCodeParamsBase.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/FileHash2ContentRequest.java
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/responses/GetAnalysisResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/core/AnalysisDataBase.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/FileHashRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/ExtendBundleRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/ExtendBundleRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/ExtendBundleRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/ai/deepcode/javaclient/requests/FileContentRequest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.