Skip to content
This repository was archived by the owner on Feb 1, 2023. It is now read-only.

Use new snyk code api [ROAD-495] #28

Merged
merged 11 commits into from
Nov 29, 2021

Conversation

bastiandoetsch
Copy link
Collaborator

No description provided.

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner November 23, 2021 14:39
@bastiandoetsch
Copy link
Collaborator Author

Fails because the API answered to slow. I'll add a loop to wait for completion.

@ArtsiomCh
Copy link
Contributor

@bastiandoetsch does that require any changes in the plugin as well? if so, could you please open PR with such changes so we could check how it works all together?

@bastiandoetsch
Copy link
Collaborator Author

@ArtsiomCh Only referencing the new client. No code update should be needed, just a dependency update.

@michelkaporin
Copy link
Contributor

michelkaporin commented Nov 24, 2021

@bastiandoetsch @aldanchenko Is the way bundle gets created here (sending hash + file contents in the first API request) same as in Visual Studio snyk/snyk-visual-studio-plugin#61? If not, let's unify the implementation to be consistent please.

@bastiandoetsch
Copy link
Collaborator Author

I think it is working the same, but this ticket should not be about synchronizing the plugins - that would be scope creep and much potentially much bigger :).

@ArtsiomCh
Copy link
Contributor

Made a quick look... and it looks good. Well done @bastiandoetsch !
As it's a significant change, let me go through it a little bit deeper within few days.

@ArtsiomCh ArtsiomCh closed this Nov 29, 2021
@ArtsiomCh ArtsiomCh deleted the ROAD-495_implement_new_snyk_code_api branch November 29, 2021 12:04
@ArtsiomCh ArtsiomCh restored the ROAD-495_implement_new_snyk_code_api branch November 29, 2021 12:06
@ArtsiomCh ArtsiomCh reopened this Nov 29, 2021
Copy link
Contributor

@michelkaporin michelkaporin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastiandoetsch bastiandoetsch merged commit 6c539df into master Nov 29, 2021
@bastiandoetsch bastiandoetsch deleted the ROAD-495_implement_new_snyk_code_api branch November 29, 2021 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants