feat: snyk-gradle-plugin improvements #5852
Merged
+50
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitphill
force-pushed
the
feat/snyk-gradle-plugin-bump
branch
4 times, most recently
from
dccf8c8 to
043025c
Compare
gitphill
force-pushed
the
feat/snyk-gradle-plugin-bump
branch
from
043025c to
d96ca22
Compare
danlucian
approved these changes
Apr 25, 2025
Include all module artifacts as nodes in the dep-graph: snyk/snyk-gradle-plugin#299 Changes the ID of nodes in the resulting dep-graph resolved by snyk-gradle-plugin. The new node ID ensures each module artifact is identified as: `groupId:artifactId:type(:classifier)@version` where type and (optionally) classifier are new.
gitphill
force-pushed
the
feat/snyk-gradle-plugin-bump
branch
from
d96ca22 to
7991133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Include all module artifacts as nodes in the dep-graph:
Changes the ID of nodes in the resulting dep-graph resolved by snyk-gradle-plugin.
The new node ID ensures each module artifact is identified as:
groupId:artifactId:type(:classifier)@versionwhere type and (optionally) classifier are new.
Where should the reviewer start?
This PR simply bumps the snyk-gradle-plugin, see the plugin PR for more details.
How should this be manually tested?
snyk teston a Gradle project, to see the dep-graph usesnyk test --print-deps --json-output-file=out.jsonthencat out.json | jq .depGraph