Skip to content

Fix: support monitoring large/complex container projects #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix: support monitoring large/complex container projects #5075

merged 1 commit into from
Feb 28, 2024

Conversation

ChristinaDara
Copy link
Contributor

@ChristinaDara ChristinaDara commented Feb 26, 2024 •
edited
Loading

What does this PR do?

Bump snyk-docker-plugin version to 6.10.2 to contain the fix of supporting large/complex container project files files to fix an issue for customers.
For more details : snyk/snyk-docker-plugin#569

@ChristinaDara ChristinaDara requested a review from a team as a code owner February 26, 2024 10:49
@ChristinaDara ChristinaDara force-pushed the fix/support-monitoring-large-complex-container-projects branch from 67d0c54 to 1b6960d Compare February 26, 2024 10:50
@ChristinaDara ChristinaDara mentioned this pull request Feb 26, 2024
Closed
@ChristinaDara ChristinaDara changed the title chore: bump snyk-docker-plugin version Fix: support monitoring large/complex container projects Feb 26, 2024
@ChristinaDara ChristinaDara force-pushed the fix/support-monitoring-large-complex-container-projects branch from 1b6960d to f1d6eb6 Compare February 26, 2024 10:56
@ChristinaDara ChristinaDara force-pushed the fix/support-monitoring-large-complex-container-projects branch from f1d6eb6 to a3f6984 Compare February 26, 2024 15:15
cmars
cmars approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes look straightforward and do not seem to change the UX.

Tested this branch locally on a container image with JARs in it to exercise the changes in code paths (confluentinc/cp-kafka) and check for regressions, it seems fine.

@cmars
Copy link
Contributor

cmars commented Feb 26, 2024

CI failures could be Snyk API flakes, you might just need to re-run again in CircleCI.

@pecodez pecodez force-pushed the fix/support-monitoring-large-complex-container-projects branch from a3f6984 to c40fd59 Compare February 28, 2024 12:32
@pecodez pecodez enabled auto-merge (squash) February 28, 2024 13:32
@pecodez pecodez disabled auto-merge February 28, 2024 13:33
@thisislawatts thisislawatts merged commit 091e277 into main Feb 28, 2024
@thisislawatts thisislawatts deleted the fix/support-monitoring-large-complex-container-projects branch February 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmars cmars cmars approved these changes

@thisislawatts thisislawatts Awaiting requested review from thisislawatts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristinaDara @cmars @thisislawatts