-
Notifications
You must be signed in to change notification settings - Fork 619
feat: Support OAuth Client Credentials Grant [HEAD-873] #4970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
06f11ae
feat: Support OAuth Client Credentials Grant
PeterSchafer 7828997
chore: improve help and remove obsolete test
PeterSchafer 49bea3d
fix: adapt test expectation to new behaviour
PeterSchafer 19c24f9
chore: added some basic oauth client cred tests
PeterSchafer 409cb76
chore: run formatter
PeterSchafer 730827c
chore: remove test token to not interfer with other tests
PeterSchafer 4e3dbc4
chore: cleanup after auth test
PeterSchafer 2bdf613
fix: add missing return
PeterSchafer e38006e
chore: use final GAF commit
PeterSchafer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { fakeServer } from '../../acceptance/fake-server'; | ||
| import { runSnykCLI } from '../util/runSnykCLI'; | ||
|
|
||
| jest.setTimeout(1000 * 60); | ||
|
|
||
| describe('Auth', () => { | ||
| let server: ReturnType<typeof fakeServer>; | ||
| let env: Record<string, string>; | ||
|
|
||
| beforeAll((done) => { | ||
| const apiPath = '/api/v1'; | ||
| const apiPort = process.env.PORT || process.env.SNYK_PORT || '12345'; | ||
| env = { | ||
| ...process.env, | ||
| SNYK_API: 'http://localhost:' + apiPort + apiPath, | ||
| SNYK_DISABLE_ANALYTICS: '1', | ||
| }; | ||
|
|
||
| server = fakeServer(apiPath, env.SNYK_TOKEN); | ||
| server.listen(apiPort, () => done()); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| server.restore(); | ||
| }); | ||
|
|
||
| afterAll((done) => { | ||
| server.close(() => done()); | ||
| }); | ||
|
|
||
| it('successfully uses oauth client credentials grant to authenticate', async () => { | ||
| const { code } = await runSnykCLI( | ||
| `auth --auth-type=oauth --client-id a --client-secret b`, | ||
| { | ||
| env, | ||
| }, | ||
| ); | ||
| expect(code).toEqual(0); | ||
|
|
||
| // delete test token | ||
| await runSnykCLI(`config unset INTERNAL_OAUTH_TOKEN_STORAGE`, { | ||
| env, | ||
| }); | ||
| }); | ||
|
|
||
| it('fails to us oauth client credentials grant to authenticate', async () => { | ||
| const { code } = await runSnykCLI( | ||
| `auth --auth-type=oauth --client-id wrong --client-secret b`, | ||
| { | ||
| env, | ||
| }, | ||
| ); | ||
| expect(code).toEqual(2); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -245,9 +245,7 @@ describe('cli args', () => { | |
| }); | ||
|
|
||
| [ | ||
| 'auth', | ||
| 'config', | ||
| 'help', | ||
| 'ignore', | ||
| 'modules', | ||
| 'monitor', | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.