Require tls >= 2.1.2 (close #548)

[sol]

No description provided.

[sol]

http-client-tls-0.3.6.4 needs a Hackage revision to add tls >= 2.1.2.

@snoyberg if you give me the appropriate permissions, then I'm happy to add it.

[snoyberg]

Thanks @sol. I think you should have permissions on Hackage now, though there may be some cache bug on Hackage (the edit page shows you as part of the maintainer set, but the view page doesn't). Let me know if you have any issues.

[sol]

@snoyberg everything working, thanks a lot.

[snoyberg]

And thank you for all the work on these packages!

[adamgundry]

This revision appears to have ruled out some legitimate install plans, e.g. https://www.stackage.org/lts-22.43 includes tls-1.8.0 and http-client-tls-0.3.6.4, but that is now out of bounds. Perhaps it is too restrictive?

[sol]

@adamgundry I only confirmed that tls == 2.1.1 results in a build failure. Let me see what I can do.

[sol]

@adamgundry from what I understand, the underlying issue is that various versions of tls do not build, likely due to wrong constraints. I'm not in a position to debug this.

How I see it, it is not harmful for new users to use a more recent version of tls.

As for existing build plans (aka version pinning, freeze files) they also need to pin the exact Hackage revision.

I would hope that both cabal freeze and Stackage handle this correctly.

@adamgundry does this lower bound cause any issues for you?

[adamgundry]

It's not a major issue for me, because indeed I can pin the Hackage index-state and/or bump tls. I was just slightly confused as by coincidence I was constructing a build plan this morning based on LTS-22.43, and tripped over the fact that the constraints in https://www.stackage.org/lts-22.43/cabal.config aren't solvable given the latest index-state. But I'm happy for you to judge what if anything should be done about this. :-)

[sol]

@adamgundry I added another Hackage revision that I think addresses this.

To make this more robust in the future I assume Stackage would just need to set the index-state of the generated cabal.config to an appropriate value (and I guess those files should really be called cabal.config.freeze). If you happen to open a feature request for this, then please tag me.

[adamgundry]

Thanks! That does indeed permit the LTS-22.43 install plan to go through.

I've opened commercialhaskell/stackage-server#344 with the Stackage feature request.