Skip to content

call _compiler_dispatch for merge_into and copy_into clauses #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

sjhewitt
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-723663: MergeInto and CopyInto do not respect schema_translate_map #371

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

This change passes the MergeInto - target, source, on and CopyInto.into values to the compiler

@github-actions
Copy link

github-actions bot commented Jan 10, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sjhewitt
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

sjhewitt and others added 16 commits April 6, 2023 15:21
* feat: Add temporary option to the create stage command.

* update changelog

* Update tests/test_create.py

Co-authored-by: Adam Ling <[email protected]>

---------

Co-authored-by: DanCardin <[email protected]>
Co-authored-by: Adam Ling <[email protected]>
* Bump up version to 1.4.8

* update version

* update release version to 1.5.0
…nowflakedb#446)

* SNOW-892284: Fix boolean parameter parsing from URL query

* Fix cache_column_metadata being parsed as connector argument

cache_column_metadata is a snowflake-sqlalchemy argument, not
a snowflake-connector-python argument so it should be set
and ommitted from the arguments list before the call to the
connector is made.

* Add link to Github issue for dealing with other URL param types

* Add patch note

* Handle case when cache_column_metadata isn't set

* Load cache_column_metadata from query

* Add fallthrough for unknown parameters

* Fix lint

* Update DESCRIPTION.md

* Add more inline documentation

---------

Co-authored-by: Saulius Beinorius <[email protected]>
sfc-gh-mraba and others added 5 commits March 25, 2024 10:19
* SNOW-1065172-gh-workflow-optimization: workflow optimisation

---------

Co-authored-by: Adam Stus <[email protected]>
Co-authored-by: Tomasz Urbaszek <[email protected]>
…nv to metadata (snowflakedb#486)

* SNOW-1324105-dependency-pinning: move versions pinning from project env to metadata

* SNOW-1324105-dependency-pinning: update version and description

* SNOW-1324105-dependency-pinning: remove duplicated command in CI job
sfc-gh-jvasquezrojas and others added 3 commits November 25, 2024 13:13
* Fix typo in README.md


---------

Co-authored-by: Norman Rosner <[email protected]>
Co-authored-by: Anthony Holten <[email protected]>
* Fix import BOOLEAN error

* Update imports

* Add test for explicit imports
@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team November 29, 2024 20:27
sfc-gh-jvasquezrojas and others added 26 commits November 29, 2024 20:34
* SNOW-1776332 Add support for OBJECT

* Updated description.md

* Add missing @pytest.mark.requires_external_volume

* Tuple validation in OBJECT class
* Fix return value of snowflake get_table_names

---------

Co-authored-by: T Pham <[email protected]>
…nowflakedb#545)

* Changed default behavior of SnowflakeDialect to disable the use of / division operator as floor div.
Changed flag div_is_floor_div to False.

* Update Description.md

* Added flag to allow customer to test new behavior of div_is_floordiv that will be introduce, using new flag force_div_floordiv allow to test the new division behavior.
Update sa14:scripts to ignore feature_v20 from execution

* Added warning for use of div_is_floor_div with `True` value.
Added tests to validate results of true and floor divisions using `force_div_is_floordiv` flag.
* Fix drop support for SA array

* Update DESCRIPTION.md
In maintenance mode, showing it in readme file
…lumns. (snowflakedb#586)

Trying to get all columns generates errors when parameters enable extra columns for describe table command.
Fixing exception caused by dependency on number of columns returned by DESCRIBE TABLE
* Fix failing tests

* Try fixing again

* Fix test third try

* Fix tests forth try, add insecure_mode instead with disable_ocsp_checks

* Remove skip, it is not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-723663: MergeInto and CopyInto do not respect schema_translate_map