Snow-1936378 add support for vector type for loader #2161
+166
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sfc-gh-pmotacki
suggested changes
May 27, 2025
| for (String col : _columns) { | ||
| try (ResultSet rs = metadata.getColumns(_database, _schema, _table, col)) { | ||
| // Check if column type is VECTOR, if true, add column name and size to vector column map. | ||
| if (rs.getString(6).equalsIgnoreCase("vector")) { |
There was a problem hiding this comment.
Could we extract the logic of this condition and name this check instead of a comment?
| @@ -83,6 +85,8 @@ public class StreamLoader implements Loader, Runnable { | |||
|
|
|||
| private List<String> _columns; | |||
|
|
|||
| private Map<String, Integer> _vectorColumns = new HashMap<String, Integer>(); | |||
There was a problem hiding this comment.
We need to update the name of this map to better communicate its function: keep column size.
| for (int i = 0; i < _columns.size(); i++) { | ||
| String colName = _columns.get(i); | ||
| if (_vectorColumns.containsKey(colName)) { | ||
| sb.append(colName + "::VECTOR(FLOAT, " + _vectorColumns.get(colName) + ")"); |
There was a problem hiding this comment.
What about INT types in a vector?
|
|
||
| @Test | ||
| @DontRunOnGithubActions | ||
| private void testMultipleVectorColumnsInTable() throws Exception { |
There was a problem hiding this comment.
We should also test the table with mixed types (the best with all types).
| for (String col : _columns) { | ||
| try (ResultSet rs = metadata.getColumns(_database, _schema, _table, col)) { | ||
| // Check if column type is VECTOR, if true, add column name and size to vector column map. | ||
| if (rs.getString(6).equalsIgnoreCase("vector")) { |
There was a problem hiding this comment.
It would be better to store metadata for all columns, not only for the vector, in my opinion.
sfc-gh-ext-simba-hx
requested review from
sfc-gh-pbulawa and
sfc-gh-dheyman
and removed request for
sfc-gh-pmotacki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-XXXXX
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: #NNNN
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.