Skip to content

Cherrypicks to aio connector part2 #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev/aio-connector
Choose a base branch
from

Conversation

sfc-gh-pczajka
Copy link
Contributor

@sfc-gh-pczajka sfc-gh-pczajka commented Jul 14, 2025

What to review?

Most of lines in this change are cherry-picks of commits already on main, majority of which can be skipped.
Below I listed all aio changes which reflect changes in sync code. To make the review easier, I arranged the commits in a way that the changes introduced ny hand follow cherry-pick they reflect

Cherry picks:

Tests

from snowflake.connector import connect
from snowflake.connector.aio import connect as aconnect

import asyncio

PAT_params = {...}
PAT_params["authenticator"] = "PROGRAMMATIC_ACCESS_TOKEN"
PAT_params["token"] = ...

async def test_pat():
   with connect(**PAT_params) as conn:
       with conn.cursor() as cur:
           cur.execute("SELECT 1")
           print(cur.fetchone())
           print("SYNC - OK")

   connection = await aconnect(**PAT_params)
   cur = connection.cursor()
   await cur.execute("SELECT 1")
   print(await cur.fetchone())
   print("ASYNC - OK")
   await connection.close()

asyncio.run(test_pat())

@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as draft July 14, 2025 11:38
Base automatically changed from cherrypicks-to-aio-connector-part1 to dev/aio-connector July 14, 2025 12:26
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part2 branch from 7f27d92 to b1cecd2 Compare July 14, 2025 12:30
@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as ready for review July 14, 2025 14:48
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part2 branch from 01e4e45 to 06b8ec9 Compare July 15, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants