Skip to content

SNOW-2171791: Add platform telemetry #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

SNOW-2171791: Add platform telemetry #2387

wants to merge 20 commits into from

Conversation

sfc-gh-sshetkar
Copy link

@sfc-gh-sshetkar sfc-gh-sshetkar commented Jul 4, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-2171791

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds platform detection mechanisms and appends them to the CLIENT_ENVIRONMENT part of the base_auth_data(). This then gets sent to the /login-request endpoint which serializes and stores this data for future use.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-sshetkar
added telemetry emission for AWS Lambda, AWS EC2, Azure VM, GCE VM, a…
3e3d732 
…nd GCE cloud run
@sfc-gh-sshetkar
added github action platform check
0d6683b
@sfc-gh-sshetkar
linter fixes
f7879bd
@sfc-gh-sshetkar
added checks for managed identity
2e5168f
@sfc-gh-sshetkar
put telemetry on a separate thread since it makes some network calls …
a8ad08d 
…and I don't want it to block the initialization
@sfc-gh-sshetkar
added check for aws identity and refactored ec2 check to use AWS library
ce185da
@sfc-gh-sshetkar
updated name for aws arn identity check function
b1734ec
@sfc-gh-sshetkar
added gcp identity checks and updated AWS checks to do generic except…
99f4bf8 
…ion checks because it throws internal exceptions now instead of requests library exceptions
@sfc-gh-sshetkar
updated azure managed identity check to go against the default snowfl…
c66c054 
…ake resource
@sfc-gh-sshetkar
switched to 0.5 second timeout because eventually it won't be run on …
d62e955 
…a background thread and switched to executing the checks in parallel for the internal metadata network calls
@sfc-gh-sshetkar
changed to return list of signals instead of dictionary of true and f…
44ac14c 
…alse values
@sfc-gh-sshetkar
switched to detect platforms by adding it to the base_auth data which…
d163d32 
… will get sent to login-request and eventually persisted in the SessionDPO
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-sshetkar
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-sshetkar sfc-gh-sshetkar added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-sshetkar