SNOW-2173966 introduce server DoP cap #2375
Open
+159
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sfan
reviewed
Jun 25, 2025
| @@ -1086,6 +1088,11 @@ def execute( | |||
| use_s3_regional_url=self._connection.enable_stage_s3_privatelink_for_us_east_1, | |||
| iobound_tpe_limit=self._connection.iobound_tpe_limit, | |||
| unsafe_file_write=self._connection.unsafe_file_write, | |||
| snowflake_server_dop_cap_for_file_transfer=getattr( | |||
| self.connection, | |||
There was a problem hiding this comment.
Out of curiosity, why is this not self._connection like above?
Comment on lines
+1854
to
+1858
| snowflake_server_dop_cap_for_file_transfer=getattr( | ||
| self.connection, | ||
| f"_{_VARIABLE_NAME_SERVER_DOP_CAP_FOR_FILE_TRANSFER}", | ||
| _DEFAULT_VALUE_SERVER_DOP_CAP_FOR_FILE_TRANSFER, | ||
| ), |
There was a problem hiding this comment.
This is used multiple times. Maybe we could create helper function?
It might be okay to expose this as a connection property as the name seems legit. This can just be called _snowflake_max_parallel_for_file_transfer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: