Skip to content

SNOW-2129602 Fix GCS staging by ensuring the endpoint has a scheme #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SNOW-2129602 Fix GCS staging by ensuring the endpoint has a scheme #2354

wants to merge 3 commits into from
+3 −0

Conversation

sfc-gh-mmishchenko
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-mmishchenko sfc-gh-mmishchenko added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Jun 11, 2025
sfc-gh-pbulawa
sfc-gh-pbulawa reviewed Jun 12, 2025
View reviewed changes
src/snowflake/connector/gcs_storage_client.py
@@ -438,6 +438,8 @@ def get_location(
if endpoint:
if endpoint.endswith("/"):
endpoint = endpoint[:-1]
if not endpoint.startswith("https://"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about creating a test for that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa left review comments

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mmishchenko @sfc-gh-pbulawa @sfc-gh-mkubik