SNOW-1983343 add timeout for ocsp root certs #2338
Open
+69
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mkubik
changed the title
sfc-gh-mkubik
added
the
DO_NOT_PORT_CHANGES_TO_SP
sfc-gh-knozderko
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers identified that ocsp root certs dictionary access may cause a deadlock when using the driver in multiple threads. We weren't able to identify the reproduction scenario so instead we agreed on introducing a parameter that allows configuring the timeout for the lock instead of waiting indefinitely.
Additionally, new parameter for OCSP revealed a problem with globally defined connection mocks in test_session_manager that got injected into unrelated tests. This was fixed by applying per-test patch instead of the global mock.