-
Notifications
You must be signed in to change notification settings - Fork 505
fix: Ensure the converter runs to_snowflake on list items #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Thank you for the PR. Could you please add a test for that case? |
@sfc-gh-pbulawa I added a test. |
@jeffsawatzky, the test is failing. Could you check the cause, please, and fix it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the warnings
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2090775: converter doesn't properly convert lists of bytes #2311
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
When the converter is converting a list, it isn't running
to_snowflake
on each element like it does when it is a single parameter.(Optional) PR for stored-proc connector: