Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Username assertion for web browser auth #2142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Username assertion for web browser auth #2142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/snowflake/connector/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ def __config(self, **kwargs):
self._token = f.read()

if not (self._master_token and self._session_token):
if not self.user and self._authenticator != OAUTH_AUTHENTICATOR:
if not self.user and self._authenticator != OAUTH_AUTHENTICATOR and self._authenticator != EXTERNAL_BROWSER_AUTHENTICATOR:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that for authentication itself user is not required, but it is required for storing a temporary credential (token) in the cache storage, to identify the owner.

# OAuth Authentication does not require a username
Error.errorhandler_wrapper(
self,
Expand Down
Loading