Skip to content

SNOW-826296 missing parameter in script #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented May 24, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-826296

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Fixing Jenkins Arm tests.

@sfc-gh-mkeller sfc-gh-mkeller added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label May 24, 2023
@sfc-gh-mkeller sfc-gh-mkeller changed the title SNOW-826196 missing parameter in script SNOW-826296 missing parameter in script May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1579 (27ead47) into main (faa906b) will increase coverage by 0.93%.
The diff coverage is 94.27%.

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   81.50%   82.43%   +0.93%     
==========================================
  Files          61       62       +1     
  Lines        8558     8815     +257     
  Branches     1263     1305      +42     
==========================================
+ Hits         6975     7267     +292     
+ Misses       1256     1213      -43     
- Partials      327      335       +8     
Impacted Files Coverage Δ
src/snowflake/connector/__init__.py 100.00% <ø> (ø)
src/snowflake/connector/_sql_util.py 95.83% <ø> (ø)
src/snowflake/connector/auth/default.py 94.73% <ø> (ø)
src/snowflake/connector/auth/oauth.py 80.95% <ø> (ø)
src/snowflake/connector/auth/okta.py 83.15% <ø> (ø)
src/snowflake/connector/auth/usrpwdmfa.py 72.72% <ø> (ø)
src/snowflake/connector/azure_storage_client.py 90.90% <ø> (-0.76%) ⬇️
src/snowflake/connector/connection_diagnostic.py 10.19% <ø> (+0.02%) ⬆️
src/snowflake/connector/description.py 100.00% <ø> (ø)
src/snowflake/connector/errorcode.py 100.00% <ø> (ø)
... and 52 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-kdama sfc-gh-kdama merged commit 36e20a0 into main May 24, 2023
@sfc-gh-kdama sfc-gh-kdama deleted the mkeller/SNOW-826296-snowsql_build_images branch May 24, 2023 22:33
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants