Skip to content

SNOW-733718 Fix remove_comments when comments are at end of line #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

SNOW-733718 Fix remove_comments when comments are at end of line #1474

merged 1 commit into from
Mar 14, 2023

Conversation

sfc-gh-sfan
Copy link
Contributor

Description

Before the fix, the remove_comments operation will swallow the final line break, which breaks user query if there is no spaces between two lines.

Testing

Added a new unit test

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-733718

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-sfan
SNOW-733718 Fix remove_comments when comments are at end of line
d5de75c 
Description

Before the fix, the remove_comments operation will swallow the final
line break, which breaks user query if there is no spaces between
two lines.

Testing

Added a new unit test
@sfc-gh-sfan sfc-gh-sfan requested review from sfc-gh-mkeller, sfc-gh-aalam and a team March 14, 2023 00:01
sfc-gh-stan
sfc-gh-stan approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-sfan sfc-gh-sfan merged commit 277d744 into main Mar 14, 2023
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_comment branch March 14, 2023 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-stan sfc-gh-stan sfc-gh-stan approved these changes

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-sfan @sfc-gh-stan