Skip to content

SNOW-752200 reverting incorrect type-hint changes #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller commented Mar 2, 2023

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-752200
    Fixes SNOW-752200: Invalide None values in fetchmany and fetchall introduced in 3.0.1 #1464

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    There's no testing for this, mypy isn't covering cursor.py yet. However; the old type-hints were manually written by me and I suspect it was overwritten by an automated tool in eee76d1.

@codecov-commenter
Copy link

Codecov Report

Merging #1465 (f153641) into main (ec95c56) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
- Coverage   81.91%   81.81%   -0.11%     
==========================================
  Files          60       60              
  Lines        8599     8599              
  Branches     1271     1271              
==========================================
- Hits         7044     7035       -9     
- Misses       1225     1232       +7     
- Partials      330      332       +2     
Impacted Files Coverage Δ
src/snowflake/connector/cursor.py 94.66% <100.00%> (ø)
src/snowflake/connector/ocsp_snowflake.py 76.65% <0.00%> (-1.08%) ⬇️
src/snowflake/connector/cache.py 87.62% <0.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller merged commit 3ee5f5a into main Mar 3, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-752200-fetch_typehints branch March 3, 2023 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-752200: Invalide None values in fetchmany and fetchall introduced in 3.0.1
3 participants