SNOW-751214 pin tox<4 temporarily #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aling
reviewed
Mar 1, 2023
| @@ -36,7 +36,7 @@ if %errorlevel% neq 0 goto :error | |||
| call %venv_dir%\scripts\activate | |||
| if %errorlevel% neq 0 goto :error | |||
|
|
|||
| python -m pip install -U pip tox tox-external-wheels | |||
| python -m pip install -U pip "tox<4" tox-external-wheels | |||
There was a problem hiding this comment.
as an alternative, we could keep using tox4 and use the --installpkg option in tox4?
sfc-gh-kdama
approved these changes
Mar 1, 2023
sfc-gh-aling
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Relates to the new 3.0.1 release. SNOW-751214 is used to track this
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
tox-external-wheelsuses the internals oftoxwhich have changed in version 4 and above. We need to fully switch away from it before we can use the newest versions everywhere.See that this PR fixes tests:
37: https://jenkins.int.snowflakecomputing.com/job/RT-PyConnector37-Win/545/
38: https://jenkins.int.snowflakecomputing.com/job/RT-PyConnector38-Win/436/
39: https://jenkins.int.snowflakecomputing.com/job/RT-PyConnector39-Win/370/
310: https://jenkins.int.snowflakecomputing.com/job/RT-PyConnector310-Win/67/
311: