Skip to content

3.0.1 release #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2023
Merged

3.0.1 release #1446

merged 6 commits into from
Feb 28, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Getting ready for the next release!

Copy link
Collaborator

@sfc-gh-kdama sfc-gh-kdama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@sfc-gh-stan sfc-gh-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢

@sfc-gh-mkeller sfc-gh-mkeller changed the title adding changelogs 3.0.1 release Feb 27, 2023
@sfc-gh-mkeller sfc-gh-mkeller enabled auto-merge (squash) February 27, 2023 22:10
@sfc-gh-kdama
Copy link
Collaborator

@sfc-gh-mheavin Please review release notes

@sfc-gh-mkeller sfc-gh-mkeller enabled auto-merge (squash) February 27, 2023 22:19
DESCRIPTION.md Outdated

- Improved the robustness of OCSP response caching to handle errors in cases of serialization and deserialization.
- Fixed a bug where `AuthByKeyPair.handle_timeout` should pass keyword arguments instead of positional arguments when calling `AuthByKeyPair.prepare`. PR #1440 (@emilhe)
- Improved the robustness of OCSP response caching to handle errors in cases of serialization and deserialization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End each item with a period

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we don't put periods at the ends, is that something that we should be doing from now on?

Co-authored-by: Mike Heavin <[email protected]>
@sfc-gh-mkeller sfc-gh-mkeller enabled auto-merge (squash) February 27, 2023 22:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #1446 (74684e7) into main (7b00025) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
+ Coverage   81.74%   81.96%   +0.22%     
==========================================
  Files          60       60              
  Lines        8599     8599              
  Branches     1271     1271              
==========================================
+ Hits         7029     7048      +19     
+ Misses       1238     1221      -17     
+ Partials      332      330       -2     
Impacted Files Coverage Δ
src/snowflake/connector/ocsp_asn1crypto.py 75.45% <0.00%> (-2.73%) ⬇️
src/snowflake/connector/auth/_auth.py 69.86% <0.00%> (-1.03%) ⬇️
src/snowflake/connector/cursor.py 94.82% <0.00%> (+0.16%) ⬆️
src/snowflake/connector/errors.py 90.47% <0.00%> (+0.52%) ⬆️
src/snowflake/connector/ocsp_snowflake.py 77.73% <0.00%> (+1.48%) ⬆️
src/snowflake/connector/network.py 82.53% <0.00%> (+2.28%) ⬆️
src/snowflake/connector/ssl_wrap_socket.py 77.94% <0.00%> (+5.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-mkeller sfc-gh-mkeller merged commit be500a0 into main Feb 28, 2023
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/release_3.0.1 branch February 28, 2023 02:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants