-
Notifications
You must be signed in to change notification settings - Fork 31
SNOW-2111927: fix thread handle leak from event loop #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: deps/aws-sdk-1.11.283
Are you sure you want to change the base?
SNOW-2111927: fix thread handle leak from event loop #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a handle leak in the EventLoopGroup
by ensuring threads are managed rather than detached.
- Sets the thread join strategy to
AWS_TJS_MANAGED
to allow proper cleanup. - Adds a comment indicating the change for SNOW-2111927.
Comments suppressed due to low confidence (1)
crt/aws-crt-cpp/crt/aws-c-io/source/event_loop.c:124
- Add or update a unit test to verify that using
AWS_TJS_MANAGED
indeed prevents thread handle leaks when the event loop group is shut down.
thread_options.join_strategy = AWS_TJS_MANAGED;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @sfc-gh-dstempniak @sfc-gh-jszczerbinski |
teamwork issue 1265
The handle leak is from event loop having a duplicated thread handle opened in thread itself.