-
Notifications
You must be signed in to change notification settings - Fork 31
Snow-856234: Permission denied error for "/root/sf_client_config.json" #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…so that easy logging can execute properly for php driver in lib/client.c and the log levels available and used lib/logger.c to support SF_LOG_DEFAULT
…boost::filesystem::status reported by the customer
All contributors have signed the CLA ✍️ ✅ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 80.05% 79.99% -0.07%
==========================================
Files 127 127
Lines 10730 10715 -15
==========================================
- Hits 8590 8571 -19
- Misses 2140 2144 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have read the CLA Document and I hereby sign the CLA |
…e_folder to handle exceptions thrown during loading client config file
…kedb/libsnowflakeclient into SNOW-856234_easy_logging
…te, and execute to the tmp folder where sf_client_config.json is saved under does not trigger exception thrown in test case. This means need to revert to previous code to trigger exception thrown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
teamwork issue #1276
The exception that the customer reported was triggered by lack of read permission on home folder, which lead to crashing the program.
Code changes:
Implemented try-catch block to catch the exception generated from client config file so that the program can continue running without interruption