Skip to content

Snow-856234: Permission denied error for "/root/sf_client_config.json" #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-gc
Copy link
Collaborator

@sfc-gh-ext-simba-gc sfc-gh-ext-simba-gc commented Jun 26, 2025

teamwork issue #1276

The exception that the customer reported was triggered by lack of read permission on home folder, which lead to crashing the program.

Code changes:
Implemented try-catch block to catch the exception generated from client config file so that the program can continue running without interruption

…so that easy logging can execute properly for php driver in lib/client.c and the log levels available and used lib/logger.c to support SF_LOG_DEFAULT
…boost::filesystem::status reported by the customer
Copy link

github-actions bot commented Jun 26, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (196f493) to head (9c3c9cb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cpp/lib/client_config_parser.cpp 33.33% 8 Missing ⚠️
lib/client.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #902      +/-   ##
==========================================
- Coverage   80.05%   79.99%   -0.07%     
==========================================
  Files         127      127              
  Lines       10730    10715      -15     
==========================================
- Hits         8590     8571      -19     
- Misses       2140     2144       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-ext-simba-gc
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants