SNOW-1736045: update cJSON 1.7.18

[sfc-gh-ext-simba-hx]

teamwork issue 1134

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.14%. Comparing base (3acc84d) to head (7fea2ad).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   80.05%   80.14%   +0.09%     
==========================================
  Files         127      127              
  Lines       10707    10708       +1     
==========================================
+ Hits         8571     8582      +11     
+ Misses       2136     2126      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sfc-gh-jszczerbinski]

Please download the cJSON in build script as dependency and remove the copied files

[sfc-gh-ext-simba-hx]

Hi @sfc-gh-jszczerbinski

Please download the cJSON in build script as dependency and remove the copied files

cJSON is used in multiple components (curl, libsfclient, aws). The approach so far is renaming cJSON symbols (function names) in curl and libsnowflakeclient (adding prefix of sf_curl or snowflake_) so each component could have it's own copy of cJSON without symbol conflict.
To have cJSON as an independent third-party we would need to change the way how curl / awssdk are building, make them link to cJSON lib instead of using it's own copy, which might need some time to achieve.
Can we make the task separately, having cJSON updated in the existing way first, then create a follow up ticket to make cJSON as an independent third-party and have all components using it link to cJSON lib?

[sfc-gh-dstempniak]

Hi @sfc-gh-ext-simba-hx , I think it's not a top priority, let's do the integration in a separate ticket.
@sfc-gh-jszczerbinski please create a ticket in case you want it.

[sfc-gh-ext-simba-hx]

Hi @sfc-gh-dstempniak
Go head to merge this PR once you got agreement with @sfc-gh-jszczerbinski .
On the other hand there is no high CVEs in the current version (1.7.15) we are using so I think it might be OK to push this to the next release as well.

[sfc-gh-ext-simba-hx]

Please download the cJSON in build script as dependency and remove the copied files

Hi @sfc-gh-jszczerbinski I've made changes to download the cJSON in build script, removed the copied files and use patch to generate them from the downloaded one. Please take a look if that looks good I might apply the same approach when updating other dependencies later (such as aws sdk).