Skip to content

SNOW-1313651: libsfclient - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

SNOW-1313651: libsfclient - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD #873

wants to merge 34 commits into from
+595 −0

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Apr 9, 2025 •
edited
Loading

  • Added a testing case that compares the timestamp values with array binding to the timestamp values with stage bindings.

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title SNOW-1313651 while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD Apr 14, 2025
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy changed the title while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD SNOW-1313651: libsfclient - Verify value bindings for all field types while exceeding CLIENT_STAGE_ARRAY_BINDING_THRESHOLD Apr 14, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (5cc5482) to head (6a20c7f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   79.16%   77.17%   -1.99%     
==========================================
  Files         127      127              
  Lines       10718    10717       -1     
==========================================
- Hits         8485     8271     -214     
- Misses       2233     2446     +213

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sfc-gh-ext-simba-hx
sfc-gh-ext-simba-hx reviewed Apr 15, 2025
View reviewed changes
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review May 6, 2025 00:54
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner May 6, 2025 00:54
sfc-gh-dstempniak
sfc-gh-dstempniak requested changes May 26, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx Awaiting requested review from sfc-gh-ext-simba-hx

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski Awaiting requested review from sfc-gh-jszczerbinski

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-jy @sfc-gh-dstempniak @sfc-gh-ext-simba-hx