-
Notifications
You must be signed in to change notification settings - Fork 33
EventListener::new footgun #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is it because some may assume that listener starts listening immediately after being created when in reality it will listen only when awaited/.wait()'ed? |
notgull
added a commit
that referenced
this issue
Oct 18, 2023
In retrospect it is sometimes unclear in the documentation that the new event listener needs to be pinned and inserted into the list before it can receive events. This PR adds documentation that should clarify this issue. Closes #89 Signed-off-by: John Nunley <[email protected]>
notgull
added a commit
that referenced
this issue
May 4, 2024
In retrospect it is sometimes unclear in the documentation that the new event listener needs to be pinned and inserted into the list before it can receive events. This PR adds documentation that should clarify this issue. Closes #89 Signed-off-by: John Nunley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Copy&pasting from the matrix channel to avoid repeating:
The text was updated successfully, but these errors were encountered: