Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breakingChanges to the removal of sigv4 and sigv4a traits #2567

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

qijuew
Copy link
Contributor

@qijuew qijuew commented Mar 21, 2025

Background

  • The removal of sigv4 and sigv4a auth events will throw danger events since these are breaking changes
  • The addition of these danger events informs the model developer to understand the significant customer impact on the auth scheme removals

Testing

  • Local build passed with new unit test cases

Links

  • Links to additional context, if necessary: N/A
  • Issue #, if applicable: N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@qijuew qijuew requested a review from a team as a code owner March 21, 2025 20:01
@qijuew qijuew requested a review from yefrig March 21, 2025 20:01
@yasmewad yasmewad requested review from yasmewad and removed request for yefrig March 26, 2025 20:47
@yasmewad yasmewad merged commit 5ec9573 into smithy-lang:main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants