Skip to content

fix(codegen): use undefined placeholder for unhandled trait #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(codegen): use undefined placeholder for unhandled trait #1629

merged 1 commit into from
Jun 23, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jun 23, 2025 •
edited
Loading

code generates [unknownTrait]: void 0 instead of [unknownTrait]: (blank value, syntax error).

@kuhe kuhe requested a review from a team as a code owner June 23, 2025 16:25
@kuhe kuhe merged commit fdea2d7 into smithy-lang:main Jun 23, 2025
11 checks passed
@kuhe kuhe deleted the fix/schema branch June 23, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddsriv siddsriv siddsriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @siddsriv