chore(builds): skip typecheck for cjs/es artifacts #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/build-typecheck
branch
from
6a92784 to
0728336
Compare
trivikr
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking is not necessary for the CJS and ES build configurations.
This is because the dist-types build checks all types, including code inside functions that do not appear in the API type declarations. I have verified this.
Skipping type checks will improve build times and avoid redundant compilation errors printed to the console. Because all 3 dist builds run concurrently in the "build" scripts of packages, any existing type error is printed to the console 3 times in interleaved lines, resulting in a hard to read output.
savings in CI:
build packages step ~6m40s -> ~4m42s