fix(service-error-classification): add TypeError as transient error #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
force-pushed
the
browser-retries
branch
2 times, most recently
from
290d3cb to
d246976
Compare
siddsriv
commented
May 2, 2025
| return false; | ||
| } | ||
|
|
||
| return errorMessages.has(error.message); |
There was a problem hiding this comment.
doing a check for messages as well to avoid unintended TypeErrors from being retried
siddsriv
commented
May 2, 2025
| * @internal | ||
| */ | ||
| export const isBrowserNetworkError = (error: SdkError) => { | ||
| const errorMessages = new Set([ |
There was a problem hiding this comment.
this constant could be placed somewhere else, like the constants file in the same dir. I'd like this here since:
- these are not as strong a check as error codes or status codes, so I want to keep them away from other constants
- this function and its hacky message checks will be easily(-ier?) visible in the future if someone is taking a look at transient errors.
kuhe
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5890
Description of changes:
fetch API surfaces connectivity errors as TypeErrors, example:
TypeError: Failed to fetchin Chrome.For browsers, we should retry for connectivity issues (offline), this is a fix to retry on TypeErrors then. Since we don't want to retry for
TypeErrorsthat aren't network errors, I've paired this check with the actual error messages that different browsers surface (not an exhaustive list, but covers some major ones).Fetch has an open issue about this: whatwg/fetch#526
additional resources
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.