Update Whynter codes to be more reliable #1397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- codes are now generated algorithimically to be millisecond accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am the original contributor of this file, however the learned codes never seem to be reliable.
So I adapted https://github.com/esphome/esphome/blob/dev/esphome/components/whynter/whynter.cpp to generate to codes in raw form and used https://github.com/elupus/irgen to convert to Broadlink.
My adapted Python code:
https://gist.github.com/thewade/5f0d87a5e3e69455410015f4105593c0
I should also be able to generate codes for Whynter devices that support heating if someone wants it.