Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First few bits needed for handling emoji to approve merge requests. Includes first steps for #146 and #145.
A few ideas on how to improve upon this:
1. approver eligability
I think it would be best to implement this on
CODEOWNERS
file in the repo. A quicker implementation might be to add this to the.marge-bot.yml
:(which I did first but I prefer the CODEOWNERS solution so I did not publish it)
2. allow overwriting of all configs in .marge-bot.yml
As stated in #146 it would be great to overwrite the global config. But that would go in a separate merge request.
3. use marge-bot.yml from destination of merge request instead
Currently it uses the
.marge-bot.yml
config hardcoded from master, probably it would be better to use it from the merge request destination tree. Objections?4. handle down votes
My first implementation did saw any 👎 as blocker not accepting a merge request as long as there is a single 👎. As that might not be sensible to do in every environment I decided to remove handling of 👎 at all for the merge request.
I think there might be three different ways to handle this:
It is a somewhat tricky topic so I guess it got to be configurable... :]