-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Ensure all version references are up-to-date prior to release #447
ci: Ensure all version references are up-to-date prior to release #447
Conversation
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
### | ||
### SHA256SUM.md | ||
### | ||
|
||
read -r line < SHA256SUM.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### | |
### SHA256SUM.md | |
### | |
read -r line < SHA256SUM.md | |
# Read the top line of SHA256SUM.md | |
read -r line < SHA256SUM.md |
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
An issue: I just noticed that I can't find any PRs that adopt the |
We might not have released a verifier version yet with it, I don't remember. |
Right, we may want to add it to the |
I've just pushed a commit adding that instruction to RELEASE.md. I'm actually going to make a change to the script to take advantage of the fact that the version is actually declared in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
One qq -- can you fix DCO? (Or maybe TBH we should just remove it..)
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
d5f2c7c
to
3b759b2
Compare
Signed-off-by: Pedro Kaj Kjellerup Nacht <[email protected]>
Ops, hadn't noticed the DCO. Fixed. I also just submitted a new commit to use the |
We may need to require it at some point (right now it's non-blocking). The slsa repo requires it for example. |
Closes #370. Please look carefully, the workflow introduced here works on PRs, so make sure it doesn't allow untrusted content to be interpreted.
This PR adds a new pre-release check: in PRs with
#[]label:release
(adding dummy brackets not to trigger anything!) in the description, ensures that all version references are up-to-date. These include:go.mod
;SHA256SUM.md
(in both the link and the text);README.md
.Should any inconsistencies be found, the logs will display them, for example:
The logic for the README is brittle, relying on the fact that all current version references there are prefixed by the string
slsa-verifier
. Should this change in the future, the logic may need to change.Also, this logic currently runs on all PRs marked with
#[]label:release
. Should release-candidate PRs be omitted?