-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add release workflow test at presubmit #212
Conversation
Signed-off-by: Asra Ali <[email protected]>
@laurentsimon do you know why the go builder at v1.2.0 is failing? |
not sure. We don't officially support PR, maybe there's something going on there. Maybe the OIDC token is failing (not |
so it knows what to fetch. However, there's some code that validates the repo name, and only allow example-package and / or this repo.. maybe that's what's going on. |
Ah I see. Maybe I should just run this on schedule instead. |
Btw, how are we going to keep this pre-submit in sync with the release workflow? I mean, that the versions are the same?Shall we use the same workflow and add a trigger to it? Or use a workflow_run trigger and trigger it on PR and during release? Do we need to |
Yeah, let's nuke the separate workflow, and use the same one. Instead of on PR, we can trigger once daily or something on schedule just for testing? This way we can still keep the on push tags for automatic upload |
If that simplifies our life, I think that works. Let's create an issue when that happens. |
+1. The code is for the generator anyway, so need to run on each PR. |
Signed-off-by: Asra Ali <[email protected]>
nice! done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali [email protected]
To ensure that the release workflow will work before we push a release, because maybe the releaser config went stale.
fixes #211