Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation passes if no artifact argument is supplied #425

Closed
mihaimaruseac opened this issue Dec 29, 2022 · 0 comments · Fixed by #426
Closed

Validation passes if no artifact argument is supplied #425

mihaimaruseac opened this issue Dec 29, 2022 · 0 comments · Fixed by #426

Comments

@mihaimaruseac
Copy link
Contributor

mihaimaruseac commented Dec 29, 2022 •
edited
Loading

I think I added a regression in #419 . Now we can also pass 0 binaries and the verification passes:

[...]$ slsa-verifier verify-artifact --provenance-path multiple.intoto.jsonl --source-uri github.com/some/repo
PASSED: Verified SLSA provenance

I'll send a quick fix shortly. Found during #424
mihaimaruseac added a commit to mihaimaruseac/slsa-verifier that referenced this issue Dec 29, 2022
@mihaimaruseac
fix: Expect at least one artifact in verification
8d3f6c6 
Fixes slsa-framework#425 introduces by slsa-framework#419

Signed-off-by: Mihai Maruseac <[email protected]>
@mihaimaruseac mihaimaruseac mentioned this issue Dec 29, 2022
Merged
laurentsimon pushed a commit that referenced this issue Dec 29, 2022
@mihaimaruseac
fix: Expect at least one artifact in verification (#426)
17463c0 
* fix: Expect at least one artifact in verification

Fixes #425 introduces by #419

Signed-off-by: Mihai Maruseac <[email protected]>

* go fmt

Signed-off-by: Mihai Maruseac <[email protected]>

Signed-off-by: Mihai Maruseac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Expect at least one artifact in verification mihaimaruseac/slsa-verifier
1 participant
@mihaimaruseac