Skip to content

fix: verify-checkout uses wrong sha to validate for pull_requests #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

laurentsimon
Copy link
Collaborator

This is the reason the pre-submits are currently failing for renovatebot.

@laurentsimon laurentsimon enabled auto-merge (squash) September 29, 2022 23:30
@laurentsimon laurentsimon changed the title fix: checkout-verif uses wrong sha to validate for pull_requests fix: verify-checkout uses wrong sha to validate for pull_requests Sep 29, 2022
Copy link
Member

@ianlewis ianlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, how did this ever work?

@laurentsimon laurentsimon merged commit fc65005 into slsa-framework:main Sep 30, 2022
@laurentsimon
Copy link
Collaborator Author

It never did, because we never bumped the versions. I'm hoping to get rid of all the pinning in #880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants