fix: inject headers defined in vite config #2191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 👋 Thanks for the amazing project! 🤩
This PR fixes an issue that I've run into when trying to use
@webcontainer/api
withslidev
. The problem is thatslidev
ignores theserver.headers
configuration when serving the initial page.After this PR, the
headers
field will now be respected forvite.config.ts
similar to this:For applying the headers from that field, I've followed the same logic as
vite
does for static assets. See here.Let me know if there's anything I should do! 🙌