-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: support open graph protocol #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support open graph protocol #2096
Conversation
❌ Deploy Preview for slidev failed.
|
a0e9240
to
1bd92b3
Compare
I wonder if we should use something more comprehensive like https://unhead.unjs.io to support more tags other than only og |
1bd92b3
to
290e2dc
Compare
It sounds like a good idea. I can implement it. |
@antfu Do you think we need to implement all Open Graph attributes using
Then, we can provide a It would be like the following.
|
Yeah that looks great, thanks! |
cfa4cad
to
8e8102f
Compare
@antfu Because |
ddcda87
to
dc220b2
Compare
dc220b2
to
1cbdb3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for developing this! I would love to have this feature as soon as possible!
It seems difficult to implement without using transformHtmlTemplate
, so I’m okay with using an unstable version of unhead
if necessary.
Hi, @antfu. Could you take a look when you have time? |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
Description
Support Open Graph Protocol in the headmatter. Only adding support for the following attributes:
Test Plans
Related issue