Skip to content

fix: aspectRatio type in schema #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2025
Merged

fix: aspectRatio type in schema #2089

merged 7 commits into from
Mar 31, 2025

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Feb 25, 2025

Incorrect type. Expected "number".yaml-schema: 
file:///.../antfu.slidev-51.3.0/schema/headmatter.json
Aspect ratio for slides should be like 16/9 or 1:1

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for slidev failed.

Name Link
🔨 Latest commit a0904d7
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/67ea1d8b8eea7f0008759469

Copy link
Member

@kermanx kermanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that

config.aspectRatio = parseAspectRatio(config.aspectRatio)
has normalized the value. All the additions of parseAspectRatio in this PR seem to be unnecessary. Correct me if I am wrong

Copy link

pkg-pr-new bot commented Mar 31, 2025

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2089

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2089

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2089

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2089

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2089

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2089

commit: a0904d7

@antfu antfu merged commit dc8b462 into slidevjs:main Mar 31, 2025
4 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants