Skip to content

Add 30x statuses as satisfied apdex requests #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JustDoItSascha opened this issue Jul 16, 2020 · 1 comment
Closed

Add 30x statuses as satisfied apdex requests #107

JustDoItSascha opened this issue Jul 16, 2020 · 1 comment
Assignees
@sv2
Labels
enhancement

Comments

@JustDoItSascha
Copy link
Contributor

Currently for the apdex score only response status codes beginning with 2xx are considered as satisfied. But I think especially a response of 304 Not Modified should also be considered as successful and not an error in terms of apdex.

The best solution would be, if it's configurable.
JustDoItSascha added a commit to JustDoItSascha/swagger-stats that referenced this issue Jul 16, 2020
@JustDoItSascha
Add 3xx status codes to successful apdex calc
c9b2a70 
Solves slanatech#107
@JustDoItSascha JustDoItSascha mentioned this issue Jul 16, 2020
Merged
@sv2 sv2 self-assigned this Oct 17, 2020
@sv2
Copy link
Collaborator

sv2 commented Oct 22, 2020

Addressed in 0.95.18

@sv2 sv2 closed this as completed Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sv2 sv2

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sv2 @JustDoItSascha