Skip to content

docs: shortens readme due to new tools site docs #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

lukegalbraithrussell
Copy link
Contributor

Summary

README short because docs site long

Requirements (place an x in each [ ])

@zimeg zimeg added the docs Improvements or additions to documentation label Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (18d0229) to head (7929dac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files           7        7           
  Lines         702      702           
=======================================
  Hits          701      701           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for such a fast follow up on this 🙏 ✨

I left a comment around wording and calling out the tools.slack.dev link that aren't blocking, and a section that perhaps we can follow up on later? Having a single source of truth for now is exciting! 📚

Comment on lines -22 to -39
## Sending variables

There are different [techniques to send data](#sending-techniques) into Slack
and whichever one is chosen will require a certain set of customized inputs, as
described later.

You can provide data to send to Slack from this GitHub Action and either source:

- The default event [context][event-context] with a [payload][event-payload]
matching the GitHub event.
- A custom payload with optional [variables][variables] provided in the GitHub
Action step.

These input options are valid for all techniques, but some techniques require
specific constraints with certain requirements for valid inputs.

Additional [configurations](#additional-configurations) and other details are
also available for more customizations to the provided payload.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I'm thinking this section might be nice to include on the website's sidebar?

Linking to a specific technique left some confusion about these details for me 🔍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh yeah i can see that. i'll make a follow up task!

Co-authored-by: Eden Zimbelman <[email protected]>
@lukegalbraithrussell lukegalbraithrussell merged commit 9e9c4b1 into main Apr 3, 2025
7 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-streamline-readme branch April 3, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants