Skip to content

Set common application name for data protection between Admin and STS. #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

aiscrim
Copy link
Contributor

@aiscrim aiscrim commented Mar 24, 2020

Fixes #510

@b0
Copy link
Contributor

b0 commented Mar 24, 2020

Hi @aiscrim,

yeah, that's exactly it! - but maybe just for futures sake instead of "Skoruba.IdentityServer4" you make it "Skoruba.IdentityServer" ? Does it have sense @skoruba ?

I know, it's nothing special but it's mater of time when that number will change...

Thank all of you and take care of yourself

@skoruba
Copy link
Owner

skoruba commented Mar 28, 2020

What about API project? :)

@aiscrim
Copy link
Contributor Author

aiscrim commented Mar 28, 2020

The Api doesn’t generate AntiForgery tokens nor reset tokens (if I’m not missing something), so it doesn’t use anything from the DataProtection Api.
Regarding the application name, let me know your decision and I can change it to whatever you think appropriate.

@b0
Copy link
Contributor

b0 commented Mar 28, 2020

I think API should have i too.
I am pretty sure in one moment we will try to rewrite STS and Admin to use same API because now we have code duplication and inconsistencies. Eg. I would like to initiate "forgotten password" flow from my own app using API... Sure, i would need to add that functionality but I would still need to provide link to STS form for setting password and STS should validate token.

If application name for data protection is not same on all projects - this will not work... :(

Best regards

@skoruba skoruba merged commit c539915 into skoruba:dev Apr 18, 2020
@skoruba skoruba mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants