Added Created HTTP response code for Role and User post methods #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmichaelx
suggested changes
Oct 24, 2019
|
I will add new project for tests regarding to API #383 |
|
Would you merge this since you are ok with it? Also, is there a "chat room" with two of you where we can discuss further developments and goals? Maybe I can help. Thank you |
|
I will test it, it would be nice implement same logic into all methods for creation of some entity. What do you think? |
|
@b0, would it be possible for you to apply same logic into all methods for creation of some entity ? |
…hub.com/b0/IdentityServer4.Admin into feature/return-created201-http-response
|
@skoruba, @xmichaelx I have added 201 response with Location header for all controllers post methods where applicable. |
|
@b0 - great work! I will test it. 👍🏼😊 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating Role or User api will return Location header with uri for new entity and json dto with id for created entity...