-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add profile management to STS, change int to default guid for Identity #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…der into separated folders.
Add reference to project of @damienbod
…koruba/IdentityServer4.Admin into feature/sts-profile-management
…mtp-sendgrid Added implementations of smtp and sendgrid email senders
…mpt configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issue with cookies not being cleaned up after password reset but other than that everything seems to work - we can check that issue out on dev branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String is actually default not because of GUID, but because of different built-in types across diferent SQL databases. Any type of key can be cast from string and checked if they are valid integers or any other type across myriad of languages.
DBs create primary keys with varchar/nvarchar (or whatever type is for string with all possible characters support). SQL Server creates nvarchar(450) PK for default string PK's in identity.
Then multiple tables with same ID become unsuitable for clustered indexes (ref dotnet/aspnetcore#5757)
Automatically, some data may not be saved due to index size violations and stuff like that.
I know this seems very philosophical, but these violations are common with SQL Server due to large indexes.
Commonly logging behavior of each user login can create large data-sets. And for better SQL performance clustered index may be viable. SQL Server has 900-byte constraint on this. And kaboom.
Perfectly legal data becomes unsaveable due to clustered index size constraint.
This should be added in docs, or at least a reference to dotnet/aspnetcore#5757
so a user is notified of possible shortcomings of this type of key on some datastores
@duki994 - Thank you for good points! |
You have to use SignInManager SignOutAsync to sign out async.
BUT (a big but) That's reason why SignInManager and SignOutAsync actually exist in ASP.NET Identity. dotPeek and many IL decompilers have witnessed how much time many of my colleagues and I lost on this issue. Found the issue while writing comment: DuendeArchive/IdentityServer4#2087 I will do a PR on weekend to add this stuff to docs. |
@duki994 - We are using |
Uh oh!
There was an error while loading. Please reload this page.