[skip ci] Try to fix broken API docs #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tabulate to requirements and see if that fixes the broken API docs. In the RTD logs, there is a warning about this dependency missing, but it's unclear if it is related to the error.
thomasjpfan
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tabulate to the doc requirements seems to fix the broken API docs reported in #967.
Here is an example page on latest that is currently broken: https://skorch.readthedocs.io/en/latest/callbacks.html
Here is the same page on this branch which is fixed: https://skorch.readthedocs.io/en/docs-fix-broken-api-docs/callbacks.html
I'm not quite sure why the missing dependency wasn't a problem earlier but now is, but adding it should do no harm.