Fix a bug that led to double-registration #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cloning a net, _module, _criteria, and _optimizers are already populated. Then, when loading params, there is yet another registration, i.e. a double registration. As a consequence, there would be two 'modules' etc. This is a fix for that.
4 tasks
thomasjpfan
reviewed
Jun 13, 2021
| if self.init_context_ == 'module': | ||
| # make sure to not double register -- this should never happen, but | ||
| # still better to check | ||
| if (self.init_context_ == 'module') and (name not in self._modules): | ||
| self._modules = self._modules[:] + [name] |
There was a problem hiding this comment.
I think this is what fixed the bug. Would a set be a better data structure for _modules?
Comment on lines
+1797
to
+1798
| to_exclude = {'_modules', '_criteria', '_optimizers'} | ||
| return {key: val for key, val in params.items() if key not in to_exclude} |
There was a problem hiding this comment.
On master, these attributes are not included in get_params.
There was a problem hiding this comment.
What do you mean? On current master, after merging #751, get_params includes those.
There was a problem hiding this comment.
Ah I was mistaken. (I was on a older version of master locally)
Can we add a test here:
skorch/skorch/tests/test_net.py
Line 1409 in 812f54d
Something like:
assert `_modules` not in paramsThere was a problem hiding this comment.
Good idea. I added a separate test below because that one was already big enough.
Test that get_params does not return any of the unwanted keys.
thomasjpfan
approved these changes
Jun 19, 2021
BenjaminBossan
deleted the
bugfix/module-double-registration-after-clone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug introduced by a last minute change in #751
After
cloneing a net,_module,_criteria, and_optimizersare alreadypopulated. Then, when loading params, there is yet another registration,
i.e. a double registration. As a consequence, there would be two
'modules'etc. This is a fix for that.The solution is a two-pronged: Don't return
_modulesetc. when cloning,and make a safety check during registration. Either of those should be
sufficient, but it's probably better to be extra safe.