Skip to content

FIX Allows TrainEndCheckpoint to be unpickled #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2021
Merged

FIX Allows TrainEndCheckpoint to be unpickled #778

merged 2 commits into from
May 30, 2021

Conversation

thomasjpfan
Copy link
Member

Fixes #773

Removes __getattr__ from TrainEndCheckpoint. This should not be BC breaking because Checkpoint does not set attributes that is not already set in TrainEndCheckpoint.

Alternative to #774

@thomasjpfan thomasjpfan mentioned this pull request May 29, 2021
Closed
@BenjaminBossan
Copy link
Collaborator

The less we have to rely on __getattr__ et al., the better. Therefore, I like your solution better. Could you please add an entry to CHANGES.md?

@BenjaminBossan BenjaminBossan merged commit 37313f5 into skorch-dev:master May 30, 2021
@BenjaminBossan
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TrainEndCheckpoint can't be pickled
2 participants
@thomasjpfan @BenjaminBossan