Fix a bug with custom attribute name clashes #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user adds a new "settable" attribute (i.e. that works with
set_params) whose names starts the same as an existing attribute (say
"optimizer_2"), and adds a corresponding argument (say
"optimizer_2__lr"), skorch will erroneously complain about this
argument because it thinks it belongs to the other
attribute ("optimizer" in this example). The added unit test should
illustrate this behavior.
thomasjpfan
reviewed
Feb 12, 2020
| @@ -1334,7 +1334,7 @@ def _check_kwargs(self, kwargs): | |||
| for key in kwargs: | |||
| if key.endswith('_'): | |||
| continue | |||
| for prefix in self.prefixes_: | |||
| for prefix in sorted(self.prefixes_, key=lambda s: (-len(s), s)): | |||
There was a problem hiding this comment.
For future maintainability, add a comment about why this sorting is needed or at least a link to this issue. (It is not obvious at first glance why this is needed)
There was a problem hiding this comment.
I added a comment
sthagen
added a commit
to sthagen/skorch-dev-skorch
that referenced
this pull request
Feb 16, 2020
Fix a bug with custom attribute name clashes (skorch-dev#590)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user adds a new "settable" attribute (i.e. that works with
set_params) whose names starts the same as an existing attribute (say"optimizer_2"), and adds a corresponding argument (say
"optimizer_2__lr"), skorch will erroneously complain about this
argument because it thinks it belongs to the other
attribute ("optimizer" in this example). The added unit test should
illustrate this behavior.