Skip to content

[BUG] TrainEndCheckpoint not working with LoadInitState #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
YannDubs opened this issue Sep 17, 2019 · 1 comment · Fixed by #536
Closed

[BUG] TrainEndCheckpoint not working with LoadInitState #528

YannDubs opened this issue Sep 17, 2019 · 1 comment · Fixed by #536
Labels
bug

Comments

@YannDubs
Copy link
Contributor

I'm trying to use TrainEndCheckpoint with LoadInitState but it's not working. It doesn't even return any error as you are using with suppress(Exception). The suppressed error is *** AttributeError: 'TrainEndCheckpoint' object has no attribute 'f_history_', yet the file exists and self.checkpoint.checkpoint_.f_history_==.../train_end_history.json'.

I think the issue is that TrainEndCheckpoint stopped inheriting from Checkpoint in #463. I.e. it doesn't have a f_history_ attribute anymore. This could be simply resolved by redirecting self.f_history_ to self.checkpoint_.f_history_.
@BenjaminBossan
Copy link
Collaborator

Thank you very much for this detailed investigation. We will look into this.

BenjaminBossan added a commit that referenced this issue Sep 21, 2019
@BenjaminBossan
Fix bug #528
c4e4bc9
@BenjaminBossan BenjaminBossan mentioned this issue Sep 21, 2019
Merged
ottonemo pushed a commit that referenced this issue Oct 2, 2019
@BenjaminBossan @ottonemo
Bugfix/train end cp with load init state 528 (#536)
3aa9b43 
* Renamed fixture in test for TrainEndCheckpoint

The callback was renamed but the fixtures still referenced the old
name.

* Fix bug #528

* Add entry to CHANGES.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/train end cp with load init state 528 skorch-dev/skorch
2 participants
@BenjaminBossan @YannDubs