Fixes/server #12
Merged
Fixes/server #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates changes to the handling of argument handling
…n due to busage on osx ventura
Feature/stacks
…ing or an int based on the server being a vps or a cloud server
…ld go in terraform. but feels like addressing api quirks should live with the api
tommysitehost
force-pushed
the
dev
branch
2 times, most recently
from
aa14ef3 to
09d39c1
Compare
|
Hi @yakmoose, Thank you for pointing this out. We are aware of this issue and will have internal discussions around standardising the return types across all our endpoints. We will merge your MR, use it as a work around for now. I will create GitHub issues around these areas so we can keep track of it. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small fix to stop the unmarshalling from spewing on the server list endpoint.
It currently returns disk sizes as either a string representing a number, or a number/int depending on the type of server. Cloud containers return an int, where as the other types use a string.
This wraps the field as a
MaybeInttype that has an unmarshaller to handle so we don't get things breaking, at least until someone can fix the api :)Cheers