Test with Go 1.12 #927
Test with Go 1.12 #927
Conversation
Makefile
Outdated
| go get golang.org/x/sys/unix | ||
| go get golang.org/x/sys/windows | ||
|
|
||
| .PHONY: \ |
There was a problem hiding this comment.
Isn't .PHONY supposed to be at the top of the file?
There was a problem hiding this comment.
No, I don't think so. See for example https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
.travis.yml
Outdated
| @@ -6,10 +6,7 @@ matrix: | |||
| include: | |||
| - go: 1.10.x | |||
| install: | |||
| - go get github.com/stretchr/testify/assert | |||
There was a problem hiding this comment.
Instead of introducing a new Makefile, which doesn't do much, how about adding a before_install block that is common to all blocks? https://docs.travis-ci.com/user/customizing-the-build/
There was a problem hiding this comment.
Won't that block be executed for the go module builds as well? I didn't add one because I don't wan't a go get to interfere or pollute the namespace before go mod download is executed.
There was a problem hiding this comment.
Ah, you're right. Good thinking.
Makefile
Outdated
| @@ -0,0 +1,8 @@ | |||
| installtestdeps: | |||
There was a problem hiding this comment.
I'd rather not add a makefile for just a single phony target.
|
Updated the PR to not use a Makefile. |
|
@ceh thanks for your contribution |
Test with Go 1.12
Add Go 1.12 to Travis CI build matrix.
AppVeyor doesn't seem to support Go 1.12 out of the box yet according to https://www.appveyor.com/docs/windows-images-software/#golang, deferring for later.