Skip to content

Fix caught signals check #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Fix caught signals check #31

merged 2 commits into from
Apr 9, 2023

Conversation

w0nsh
Copy link
Contributor

@w0nsh w0nsh commented Jun 18, 2022

Hi.
The caughtSignals mask should be shifted by one, since the first bit corresponds to the signal with number 1.

@Michcioperz
Copy link
Member

I think I need another pair of eyes on this, but it does seem to make sense

Copy link
Member

@Wolf480pl Wolf480pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, tested and indeed the lowest bit of SigCgt mask corresponds to signal 1, not 0, at least on kernels 5.15 and 3.13.
The fix is correct, but it I think it needs a comment in the code explaining why we shift.

Copy link
Member

@Wolf480pl Wolf480pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct but requires a comment in the code explaining why the shift. ( misclicked accept, sorry)

@Wolf480pl Wolf480pl merged commit c1a8669 into sio2project:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants